Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nightly build #1187

Closed
wants to merge 2 commits into from
Closed

Remove nightly build #1187

wants to merge 2 commits into from

Conversation

Bambooin
Copy link
Collaborator

Pull request

Remove nightly build job

  1. This is duplicated with commit ci
  2. This will break all forked repo without secret setting
  3. The ci status failed due to nightly build

Issue tracker

Fixes will automatically close the related issues

Fixes #

Feature

Describe features of pull request

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

1. This is duplicated with commit ci
2. This will break all forked repo without secret setting
3. The ci status failed due to nightly build
@WhiredPlanck
Copy link
Collaborator

WhiredPlanck commented Jan 18, 2024

Commit CI just provide a debug version of the app (which is more useful for developer), and requires users to login in to get its artifacts. That's not good enought. It's possible to make the Nightly build only available in this repository and not in its forks. I will work for it.

Nightly build failure is mainly caused by make release, the first thing it does is copying OpenCC's data to app assets directory. But due to our cache mechanism, which will not fetch submodules if there are caches to utilize, copying OpenCC's data could be never succeeded, and contribute to the CI failure. All of these can be fixed, don't worry.

@WhiredPlanck
Copy link
Collaborator

It's possible to make the Nightly build only available in this repository and not in its forks. I will work for it.

P.S. I don't do this because I tested the Release build on my fork. It may be the time to improve.

@Bambooin
Copy link
Collaborator Author

Found another issue: the nightly tag breaks change log generation.

If we want provide direct download for user without login, we can add another workflow.

  1. It won't break the current release flow.
  2. Logic is clear
  3. Single responsibility principle

If the pull request was approved, the nightly must be removed or it will break current release flow.

@Bambooin Bambooin closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants